Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for Armstrong Number + Typo fix in Trie.md in /en #251

Closed
wants to merge 2 commits into from

Conversation

SpiderMath
Copy link
Contributor

@SpiderMath SpiderMath commented Dec 10, 2024

Description

This pull request adds documentation for the algorithm for checking if a number is an Armstrong Number, the link to the entry is here. I plan to add further documentation for other entries but I am starting with low hanging fruit for now.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing checks pass.
  • No plagiarized, duplicated, or repetitive documentation that has been directly copied from another source.
  • If it's a new explanation, it contains solid, understandable, and accessible information.
  • I have read the whole contributing guidelines and agree to the Code of Conduct.

Screenshots (if any)

None in this case

Note to reviewers

I'm rather unsure about the quality of my pseudocode, I feel it may be too spammy with comments or code-like to be pseudocode. Please review that bit. And the codespell action fails due to a typo in a completely different file I didn't touch, hence I haven't touched it in this case. I corrected the typo in question, in /en/Data Structures/Tries/trie.md

@SpiderMath
Copy link
Contributor Author

Considering that the codespell is failing due to trie.md, I fixed it (revelant to relevant) and I've edited the title accordingly.

@SpiderMath SpiderMath changed the title Added documentation for Armstrong Number Added documentation for Armstrong Number + Typo fix in Trie.md in /en Dec 10, 2024
@SpiderMath
Copy link
Contributor Author

@vbrazo @Panquesito7 @appgurueu
Could I get some sort of response? This has been sitting in here for the past month, and I really wish to contribute the docs to be more complete! I don't think making a bunch of PRs would be helpful for y'all though, hence I was thinking about going one-by-one.

Copy link

github-actions bot commented Feb 8, 2025

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 8, 2025
Copy link

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions!

@github-actions github-actions bot closed this Feb 15, 2025
@SpiderMath
Copy link
Contributor Author

Well... that was strange.
@Panquesito7 @vbrazo @appgurueu, sorry to bother you again but some updates would be nice. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant